Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI work (resolves #225) #227

Merged
merged 12 commits into from
Jul 13, 2023
Merged

Make CI work (resolves #225) #227

merged 12 commits into from
Jul 13, 2023

Conversation

curledUpSheep
Copy link
Contributor

@curledUpSheep curledUpSheep commented Jul 13, 2023 •
edited
Loading

See #225.

I strongly suggest going commit by commit.

My approach to the linting fixes:

  • Disable rules that don't seem to fit the project well
  • Fix at least all errors
  • Keep some warnings around as "things we may want to fix at a later time". These show up as warnings in VS Code and in GitHub Actions, but they don't block the pipeline.
    • It may make sense to disable some of these as well (complexity, max statements) but I'm not sure.

@curledUpSheep curledUpSheep changed the title CI (see issue #225) Make CI work Jul 13, 2023
@curledUpSheep curledUpSheep mentioned this pull request Jul 13, 2023
Closed
@curledUpSheep
winstonjs#225: Fix small typo
e43a53c
@curledUpSheep
winstonjs#225: Don't pull Mongo binary on 'npm ci' on local
8d1bf94 
By default, mongodb-memory-server pulls in a MongoDB binary on install.
On a first run of 'npm ci', this makes npm seem to hang for no reason.
No progress bar or anything is shown either.

With this change, the MongoDB binary is only downloaded when needed.
If needed, the download happens during tests, with progress indication.
No download will happen for people using local Mongo for testing.
@curledUpSheep curledUpSheep changed the title Make CI work Make CI work (resolves #225) Jul 13, 2023
DABH
DABH approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thank you for this critical and valued contribution to the transport ❤️

@DABH DABH merged commit 1b0f95d into winstonjs:master Jul 13, 2023
@curledUpSheep curledUpSheep deleted the ci-setup branch July 17, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curledUpSheep @DABH