Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mistake in documentation #2370

Closed
Rinidh opened this issue Nov 24, 2023 · 2 comments
Closed

Small mistake in documentation #2370

Rinidh opened this issue Nov 24, 2023 · 2 comments

Comments

@Rinidh
Copy link

Rinidh commented Nov 24, 2023

🔎 Search Terms

https://github.com/winstonjs/winston#usage

The problem

The comments about "Write all logs with importance level of error or less to error.log" is incorrect. It should rather be "Write all logs with importance level of error or higher to error.log"

Same applies to the next comment

This really gave me a hard time testing to find out the right way. Hope it doesn't trouble others

What version of Winston presents the issue?

v3.11.0

What version of Node are you using?

v18.18.0

If this worked in a previous version of Winston, which was it?

No response

Minimum Working Example

No response

Additional information

No response

@DABH
Copy link
Contributor

DABH commented Jan 3, 2024

Maybe it would be more clarifying to say
higher (i.e., error, fatal, but not other levels)
higher (i.e., fatal, error, warn, and info, but not trace)
just to be super explicit for folks who aren't familiar with standard logging levels. PR welcome.

cslee0034 added a commit to cslee0034/winston that referenced this issue Aug 31, 2024
- Address issue winstonjs#2370: Fixed the comments in the usage section
DABH pushed a commit that referenced this issue Oct 4, 2024
- Address issue #2370: Fixed the comments in the usage section
@DABH
Copy link
Contributor

DABH commented Oct 4, 2024

Closed via #2507

@DABH DABH closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants