Memory leak fix: do not wait for process.nextTick to clear pending callbacks
#2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the memory leak identified here: winstonjs#1871 (comment)
smashah
changed the title
process.nextTick to clear pending callbacksprocess.nextTick to clear pending callbacks
2 tasks
|
@smashah I am in favor of this change insofar as it fixes the memory issues, but it looks like this change causes tests to fail. Any chance you can investigate what's up? I would feel much happier merging if we could get the tests green :) |
|
@DABH I've resolved the linting failures, tests seem to pass here with and without the transport changes also. |
|
Thanks again! Let's hope this resolves any memory issues once and for all! |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the memory leak identified here:
#1871 (comment)