Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert for 2103 #2104

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Revert for 2103 #2104

merged 3 commits into from
Apr 4, 2022

Conversation

wbt
Copy link
Contributor

@wbt wbt commented Apr 4, 2022

Reverts the commits which appear likely to be causing #2103 to avoid unintentionally breaking code that uses Winston.

@wbt wbt requested a review from maverick1872 April 4, 2022 22:10
@wbt wbt merged commit 7937f33 into master Apr 4, 2022
@wbt wbt deleted the revert-for-2103 branch April 4, 2022 22:10
@wbt
Copy link
Contributor Author

wbt commented Apr 4, 2022 •
edited
Loading

Note: the failed CI check was a decrease in test code coverage understandably associated with reverting a PR that increased it.

@wbt wbt removed the request for review from maverick1872 April 4, 2022 22:12
@bensandee bensandee mentioned this pull request May 20, 2022
Closed
@snyk-omar snyk-omar mentioned this pull request Oct 22, 2022
Open
@hraban hraban mentioned this pull request Dec 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wbt