Fix FileDescriptors release on file rotate [#2100] #2115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a test is failing, expecting a file to exist which does not. Can someone volunteer to look into why that's happening? |
DABH
approved these changes
Jan 7, 2024
|
I tend to agree with the comment in #2301 (comment) -- I think this PR is a bit too aggressive and will break log rotation in other ways. #2301 appears to have fixed the issue reported in #2100, at least for me, so I'm going to go ahead and close this PR for now. But if you think that something like this is still needed, feel free to let me know / open a new issue. Thank you for your contributions to winston! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @kpalumbokitu in #2100 the file descriptors for rotated logs were not released after rotation. This change is an copy of the code provided by @kpalumbokitu in #2100.
This code works for me and also solves the problem of winston writing to multiple logfiles at the same time as reported in #1972 and #1905.