fix #1732 #2272
Merged
fix #1732 #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM in the cursory review I'm able to give. Not sure if @DABH can give a more detailed review. |
|
Seems okay to me as well. I don't have a better way to test things than by using our existing test matrix. I think we have to go ahead and merge this, and if we get reports of issues, that should be a call for the community to contribute additional tests... Thanks @MoritzLoewenstein for the contribution! |
DABH
approved these changes
Feb 8, 2023
renovate bot
referenced
this pull request
in tsangste/nx-package-test
Sep 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@swc/helpers](https://swc.rs) ([source](https://togithub.com/swc-project/swc)) | [`0.5.1` -> `0.5.2`](https://renovatebot.com/diffs/npm/@swc%2fhelpers/0.5.1/0.5.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [winston](https://togithub.com/winstonjs/winston) | [`3.8.2` -> `3.10.0`](https://renovatebot.com/diffs/npm/winston/3.8.2/3.10.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>swc-project/swc (@​swc/helpers)</summary> ### [`v0.5.2`](https://togithub.com/swc-project/swc/compare/c77f175ace114c12a783b387c42002de1c21ce3a...d15eaf05cd50dc4700d0e2ceeee828bced1a1f74) [Compare Source](https://togithub.com/swc-project/swc/compare/c77f175ace114c12a783b387c42002de1c21ce3a...d15eaf05cd50dc4700d0e2ceeee828bced1a1f74) </details> <details> <summary>winstonjs/winston (winston)</summary> ### [`v3.10.0`](https://togithub.com/winstonjs/winston/releases/tag/v3.10.0) [Compare Source](https://togithub.com/winstonjs/winston/compare/v3.9.0...v3.10.0) - Avoid potential github issues - relax engines node requirement in package.json [`fc9c83d`](https://togithub.com/winstonjs/winston/commit/fc9c83d) - Export Logger class ([#​2181](https://togithub.com/winstonjs/winston/issues/2181)) [`eda40ef`](https://togithub.com/winstonjs/winston/commit/eda40ef) - Added Lazy option to file transport ([#​2317](https://togithub.com/winstonjs/winston/issues/2317)) [`f7e7f2f`](https://togithub.com/winstonjs/winston/commit/f7e7f2f) - Bump eslint from 8.32.0 to 8.44.0 ([#​2321](https://togithub.com/winstonjs/winston/issues/2321)) [`de2e887`](https://togithub.com/winstonjs/winston/commit/de2e887) - docs([#​2319](https://togithub.com/winstonjs/winston/issues/2319)): Syntax error on README.md ([#​2320](https://togithub.com/winstonjs/winston/issues/2320)) [`fcc69ec`](https://togithub.com/winstonjs/winston/commit/fcc69ec) - fix(types): Allow any object to be passed as meta to logger.profile ([#​2314](https://togithub.com/winstonjs/winston/issues/2314)) [`9d6001a`](https://togithub.com/winstonjs/winston/commit/9d6001a) - Bump [@​types/node](https://togithub.com/types/node) from 18.11.18 to 20.3.1 ([#​2313](https://togithub.com/winstonjs/winston/issues/2313)) [`06e3165`](https://togithub.com/winstonjs/winston/commit/06e3165) - Update supported Node versions and run npm audit fix ([#​2315](https://togithub.com/winstonjs/winston/issues/2315)) [`61e2f5b`](https://togithub.com/winstonjs/winston/commit/61e2f5b) - Bump [@​babel/core](https://togithub.com/babel/core) from 7.20.12 to 7.22.1 ([#​2309](https://togithub.com/winstonjs/winston/issues/2309)) [`7643ad6`](https://togithub.com/winstonjs/winston/commit/7643ad6) ### [`v3.9.0`](https://togithub.com/winstonjs/winston/blob/HEAD/CHANGELOG.md#v390) [Compare Source](https://togithub.com/winstonjs/winston/compare/v3.8.2...v3.9.0) ##### Functionality changes - Handle undefined errors in getAllInfo in exception-handler in [https://github.com/winstonjs/winston/pull/2208](https://togithub.com/winstonjs/winston/pull/2208); thanks to new contributor [@​eivindrs](https://togithub.com/eivindrs) - fix: properly allow passing non-array transport in [https://github.com/winstonjs/winston/pull/2256](https://togithub.com/winstonjs/winston/pull/2256); thanks to new contributor [@​Tanuel](https://togithub.com/Tanuel) - fix [#​1732](https://togithub.com/winstonjs/winston/issues/1732) (Http Transport uses JSON format options as request options) in [https://github.com/winstonjs/winston/pull/2272](https://togithub.com/winstonjs/winston/pull/2272); thanks to new contributor [@​MoritzLoewenstein](https://togithub.com/MoritzLoewenstein) (minor version bump per comment on the issue) - fix: add guard clause to prevent FD leak in [https://github.com/winstonjs/winston/pull/2301](https://togithub.com/winstonjs/winston/pull/2301); thanks to new contributor [@​td-tomasz-joniec](https://togithub.com/td-tomasz-joniec) ##### Dependency updates by [@​dependabot](https://togithub.com/dependabot) + CI autotesting - Bump eslint from 8.23.0 to 8.32.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/winstonjs/winston/pull/2209](https://togithub.com/winstonjs/winston/pull/2209), [https://github.com/winstonjs/winston/pull/2236](https://togithub.com/winstonjs/winston/pull/2236), [https://github.com/winstonjs/winston/pull/2258](https://togithub.com/winstonjs/winston/pull/2258), & [https://github.com/winstonjs/winston/pull/2271](https://togithub.com/winstonjs/winston/pull/2271) - Bump [@​babel/core](https://togithub.com/babel/core) from 7.19.0 to 7.20.12 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/winstonjs/winston/pull/2206](https://togithub.com/winstonjs/winston/pull/2206), [https://github.com/winstonjs/winston/pull/2234](https://togithub.com/winstonjs/winston/pull/2234), [https://github.com/winstonjs/winston/pull/2259](https://togithub.com/winstonjs/winston/pull/2259), & [https://github.com/winstonjs/winston/pull/2275](https://togithub.com/winstonjs/winston/pull/2275) - Bump [@​types/node](https://togithub.com/types/node) from 18.0.0 to 18.11.18 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/winstonjs/winston/pull/2215](https://togithub.com/winstonjs/winston/pull/2215), [https://github.com/winstonjs/winston/pull/2235](https://togithub.com/winstonjs/winston/pull/2235), & [https://github.com/winstonjs/winston/pull/2264](https://togithub.com/winstonjs/winston/pull/2264) - Bump [@​babel/preset-env](https://togithub.com/babel/preset-env) from 7.19.0 to 7.20.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/winstonjs/winston/pull/2218](https://togithub.com/winstonjs/winston/pull/2218) & [https://github.com/winstonjs/winston/pull/2244](https://togithub.com/winstonjs/winston/pull/2244) - Bump safe-stable-stringify from 2.3.1 to 2.4.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/winstonjs/winston/pull/2217](https://togithub.com/winstonjs/winston/pull/2217) & [https://github.com/winstonjs/winston/pull/2292](https://togithub.com/winstonjs/winston/pull/2292) - Bump [@​babel/cli](https://togithub.com/babel/cli) from 7.18.10 to 7.19.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/winstonjs/winston/pull/2216](https://togithub.com/winstonjs/winston/pull/2216) - Bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/winstonjs/winston/pull/2260](https://togithub.com/winstonjs/winston/pull/2260) ##### Documentation changes - Fix readme typo in [https://github.com/winstonjs/winston/pull/2230](https://togithub.com/winstonjs/winston/pull/2230); thanks to new contributor [@​aretecode](https://togithub.com/aretecode) - create new example for ready to use in [https://github.com/winstonjs/winston/pull/2240](https://togithub.com/winstonjs/winston/pull/2240); thanks to new contributor [@​myagizmaktav](https://togithub.com/myagizmaktav) - minor fixes to publishing.md ##### Build Infrastructure changes - GitHub Workflows security hardening in [https://github.com/winstonjs/winston/pull/2252](https://togithub.com/winstonjs/winston/pull/2252); thanks to new contributor [@​sashashura](https://togithub.com/sashashura) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tsangste/nx-package-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> --------- Co-authored-by: Steven Tsang <steven.tsang@globacap.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 26, 2024
This was referenced Jun 1, 2024
This was referenced Sep 10, 2024
This was referenced Sep 29, 2024
](https://renovatebot.com){kind=link}
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #1732. There is still an issue with the test: mocha crashes when using the new dummyLog with the current winston version (without the fix), I dont really know how to fix that.
Ideally there should probably be a separate test for this behaviour, currently I just changed the dummyLog object.
Last but not least, I am not very confident that I didnt break other features in the process, although all tests passed on my machine.