-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move initialization to constructor #2503
Conversation
@DABH I moved this into the constructor based on your comment in the issue but I'm still confused about how one even sees that error. What should I be running locally before opening PRs to make sure changes are good? |
Ran the
Also did
|
v3.14.2 has been published. Thanks again all! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [winston](https://github.com/winstonjs/winston) | dependencies | minor | [`3.13.1` -> `3.14.2`](https://renovatebot.com/diffs/npm/winston/3.13.1/3.14.2) | --- ### Release Notes <details> <summary>winstonjs/winston (winston)</summary> ### [`v3.14.2`](https://github.com/winstonjs/winston/releases/tag/v3.14.2) [Compare Source](winstonjs/winston@v3.14.1...v3.14.2) - Move initialization to constructor ([#​2503](winstonjs/winston#2503)) [`2458ba6`](winstonjs/winston@2458ba6) ### [`v3.14.1`](https://github.com/winstonjs/winston/releases/tag/v3.14.1) [Compare Source](winstonjs/winston@v3.14.0...v3.14.1) - Save a reference to console methods in console transport ([#​2498](winstonjs/winston#2498)) [`e82752f`](winstonjs/winston@e82752f) - Add `forceConsole` to `ConsoleTransportOptions` ([#​2496](winstonjs/winston#2496)) [`4ff0538`](winstonjs/winston@4ff0538) - Bump mocha from 10.6.0 to 10.7.0 ([#​2489](winstonjs/winston#2489)) [`62acaad`](winstonjs/winston@62acaad) - Update readme with forceConsole info ([#​2493](winstonjs/winston#2493)) [`b2b79af`](winstonjs/winston@b2b79af) ### [`v3.14.0`](https://github.com/winstonjs/winston/releases/tag/v3.14.0) [Compare Source](winstonjs/winston@v3.13.1...v3.14.0) - Add option forceConsole ([#​2276](winstonjs/winston#2276)) [`b2098fd`](winstonjs/winston@b2098fd) - Set \_rotate false on emit 'rotate' false ([#​2457](winstonjs/winston#2457)) [`1719275`](winstonjs/winston@1719275) - Bump [@​babel/core](https://github.com/babel/core) from 7.24.7 to 7.24.9 ([#​2485](winstonjs/winston#2485)) [`d2859f3`](winstonjs/winston@d2859f3) - Bump [@​babel/preset-env](https://github.com/babel/preset-env) from 7.24.7 to 7.24.8 ([#​2487](winstonjs/winston#2487)) [`71e4bb1`](winstonjs/winston@71e4bb1) - fix: readme ([#​2488](winstonjs/winston#2488)) [`0cb8c7c`](winstonjs/winston@0cb8c7c) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.vylpes.xyz/External/card-drop/pulls/352 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>
Fixes #2502