Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

upgrade dependencies, most notably: jcmturner/gokrb5(v4->v5) #12

Merged
merged 2 commits into from
Aug 1, 2018

Conversation

jcmturner
Copy link
Contributor

Update to v5 of gokrb5.

I have not been able to test the plugin as I don't have an environment to test in.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jcmturner
Copy link
Contributor Author

Hi, this seems to work for upgrading the version of gokrb5 from v4 to v5. However I can't agree to the CLA as it implies that I am giving up all rights to the code that is checked in to this repo. This may be interpreted to include that which is in the vendor directory.

@pault28
Copy link

pault28 commented Aug 1, 2018

@jcmturner I will give this a test as we actively use this plugin. See now closed jcmturner/gokrb5#156. Also this is related to #9

@ah- Any chance of reviewing this?

@ah-
Copy link
Contributor

ah- commented Aug 1, 2018

Wonderful, thanks for this! Changes look good, if @pault28 s testing works out I'll merge.

@pault28
Copy link

pault28 commented Aug 1, 2018

@ah- this works perfectly fine for windows and linux clients. +1 to merge.

@ah- ah- merged commit c9804b3 into wintoncode:master Aug 1, 2018
@ah-
Copy link
Contributor

ah- commented Aug 1, 2018

All there now, thanks for testing @pault28!

sambott pushed a commit to sambott/vault-plugin-auth-kerberos that referenced this pull request Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants