Support service principal with slash

[kristian-lesko]

Service principals containing a slash (/) prompt an error
when looking for the key in the Keytab.DecryptEncPart method
because the principal is not divided into components.

Closes #1.

[CLAassistant]

All committers have signed the CLA.

[ah-]

Thanks for this!

I'll have a look in a bit, I think the fix is correct but need to find where to best do the splitting. If the fix ends up being in gokrb we should fix it upstream rather than in our vendored copy.

[kristian-lesko]

@ah- thank you; I wasn't sure if this applies to gokrb in general, or just this plugin. If upstream happens to be the best place to fix, feel free to forward the patch there.

[ah-]

Just had a closer look and your solution seems exactly right! I've opened a PR with this change upsteam: jcmturner/gokrb5#105

Once this is merged we can update our gokrb5 dependency and have this fixed.

[kristian-lesko]

Thanks a lot for helping this patch to propagate upstream, it's great to see that it's already merged there.

I'm looking forward for when the gokrb5 dependency is updated here; this plugin is tremendously useful, and not having to rebuild it with this patch anymore will be much more practical. Thank you! :-)

[ah-]

Everything got merged now and the new 1.1.0 release should properly support this now thanks to your patch! We've also updated our vault dependency to 0.10, so you might have to update yours as well if you want to switch to it, sadly it doesn't seem easy to support both versions at the same time.

[kristian-lesko]

@ah- Thanks a lot!