does not support "[WIP]"? (update: it of course does!)

[myakura]

I see a lot of issues using wip keywords wrapped in brackets (e.g "[WIP]"). However, the current code to check whether the issue is a work in progress it does not support that pattern.

app/lib/handle-pull-request-change.js

Lines 47 to 49 in 88f6c67

	function containsWIP (string) {
	return /\b(wip|do not merge|work in progress)\b/i.test(string)
	}

Notice the leading \b. It doesn't treat brackets as word boundaries so it fails to catch issues titled "[WIP] blah".

[gr2m]

Hi @myakura, I’m pretty sure that it will it supports having "[WIP]" in the title. You can run this code in your browser console to check:

/\b(wip|do not merge|work in progress)\b/i.test('[WIP]') // returns true

I also tested it here and it works as expected: gr2m/sandbox#41

[gr2m]

Do you have a pull request in a public repository where it does not work? Can you give me a link to it?

[myakura]

@gr2m oops. lemme double check!

[myakura]

hmm. so I checked again with some repos (public & private in different orgs) and this time it worked...!
I dunno what happened. Perhaps I tested right after installing the app but it hadn't deployed yet.

Anyways, sorry for confusion. apologies.

Oh. I should've said this in the very first. Thanks for the app! This is really useful :-)

[myakura]

Okay, it looks like the bot doesn't work on PRs that already have the keywords before installing the app. Is that an intended behavior?

[gr2m]

The app only sets the status when a PR gets changed. It doesn’t check existinf PRs. But that might be a good idea :)

[myakura]

@gr2m thanks!

[gr2m]

closing in favor of #98