Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆕 After install, set status on existing pull requests #98

Closed
gr2m opened this issue Jun 27, 2018 · 4 comments · Fixed by #195
Closed

🆕 After install, set status on existing pull requests #98

gr2m opened this issue Jun 27, 2018 · 4 comments · Fixed by #195

Comments

@gr2m
Copy link
Collaborator

gr2m commented Jun 27, 2018

follow up for #97 (comment)

Currently the app does not set a status on existing pull requests. But I think it should. What’s important to consider is to throttle the requests, see https://developer.github.com/v3/guides/best-practices-for-integrators/

@gr2m
Copy link
Collaborator Author

gr2m commented Oct 24, 2018

Before working on this I need to make sure that we have propper queueing in place for the requests to avoid hitting abuse rate limits

@baiitulaman

This comment has been minimized.

@gr2m
Copy link
Collaborator Author

gr2m commented May 31, 2019

We have proper request throttling now, so let's do this.

Here is my plan:

  • Start listening to both installation event and installation_repositories event.
  • When action is deleted, just log
  • When action is created, update all open pull requests for all repositories sent in the event payload (.repositories or .repositories_added keys)
  • When action is new_permissions_accepted, update all open pull requests (for upgrades such as commit status -> check runs). The event payload has no .repositories key so we have to retrieve it first

@wipbot
Copy link

wipbot commented Jun 1, 2019

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@wipbot wipbot added the released label Jun 1, 2019
@gr2m gr2m mentioned this issue Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants