Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow mobile webapp [SQSERVICES-1831] #14595

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented Jan 31, 2023

BugSQSERVICES-1831 Bug when loading from app.wire.com through mobile device browser in Desktop mode - In Android (iOS - not an issue)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

there were several issues blocking mobile webapp/ causing inconsistencies. safari was never supported so in some cases android and ios would behave differently (one would show a login screen and then fail/ one would lock you out). it should be aligned and mobile browsing should be allowed(?)

Causes (Optional)

runtime variables are catching 'unallowed' browsers from the userAgent

Solutions

allow safari/mobile browsers

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

Notes (Optional)

I have also removed references to PWA as this concept has been scrapped and it was touching this PR it made sense to clean it out.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #14595 (d0dab65) into dev (9d037fa) will increase coverage by 0.27%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##              dev   #14595      +/-   ##
==========================================
+ Coverage   42.32%   42.59%   +0.27%     
==========================================
  Files         612      613       +1     
  Lines       20917    20925       +8     
  Branches     4793     4795       +2     
==========================================
+ Hits         8853     8914      +61     
+ Misses      10949    10898      -51     
+ Partials     1115     1113       -2     

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 42.59%. Comparing base (9d037fa) to head (d0dab65).
Report is 3172 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #14595      +/-   ##
==========================================
+ Coverage   42.32%   42.59%   +0.27%     
==========================================
  Files         612      613       +1     
  Lines       20917    20925       +8     
  Branches     4793     4795       +2     
==========================================
+ Hits         8853     8914      +61     
+ Misses      10949    10898      -51     
+ Partials     1115     1113       -2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants