Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of autodetcted links (SQSERVICES-1892) #14979

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Conversation

comawill
Copy link
Contributor

@comawill comawill commented Apr 6, 2023

BugSQSERVICES-1892 [Web] Broken encoding in links with curly braces


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Auto-detected links are not shown correctly from time to time, due to URL-escaping the whole string.

Solutions

Don't apply URL-escaping to the user presented string, instead show a popup when the URL differs from the URL, that is shown to the user in text.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

This can be verified by generating URLs similar to the ones used in the newly added tests:

Notes

This does not solve SQSERVICES-1892 completely, but it resolves the rendering issue related to it.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #14979 (4f1555e) into dev (314696a) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev   #14979      +/-   ##
==========================================
+ Coverage   42.88%   43.11%   +0.22%     
==========================================
  Files         630      641      +11     
  Lines       21439    21530      +91     
  Branches     4920     4931      +11     
==========================================
+ Hits         9194     9282      +88     
+ Misses      11078    11060      -18     
- Partials     1167     1188      +21     

@comawill comawill changed the title Fix: rendering of autodetcted links (SQSERVICES-1892) fix: rendering of autodetcted links (SQSERVICES-1892) Apr 6, 2023
@comawill comawill merged commit 5f8c448 into dev Apr 13, 2023
@comawill comawill deleted the comawill/linkify-it branch April 13, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants