feat: Export users in backups #15072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15072 +/- ##
=======================================
Coverage 43.20% 43.21%
=======================================
Files 645 645
Lines 21613 21632 +19
Branches 4956 4959 +3
=======================================
+ Hits 9338 9348 +10
- Misses 11090 11099 +9
Partials 1185 1185 |
atomrc
force-pushed
the
feat/user-backup
branch
from
d8e4ef4
to
c4b4152
Compare
atomrc
force-pushed
the
feat/user-backup
branch
from
5f1a018
to
761a9e8
Compare
przemvs
reviewed
Apr 26, 2023
| @@ -71,6 +72,57 @@ const messages = [ | |||
| }, | |||
| ]; | |||
|
|
|||
| const users = [ | |||
There was a problem hiding this comment.
We don't have user generator? 🤔
There was a problem hiding this comment.
Damn, you are completely right. Good call 👍
przemvs
reviewed
Apr 26, 2023
| usersChunk, | ||
| user => constructUserPrimaryKey(user.qualified_id), | ||
| ); | ||
| importedEntities += usersChunk.length; |
There was a problem hiding this comment.
Move usersChunk.length to variable. You using it there multiple times :)
PatrykBuniX
approved these changes
Apr 26, 2023
przemvs
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of saving users' metadata in backups.
This will export the data (but not load it yet, this will be done in a followup PR)