Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add confirmation modal pre video call, make style changes local to calling modal #15182

Merged
merged 8 commits into from
May 15, 2023

Conversation

arjita-mitra
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • Prevent accidental calls in large groups [Web] Confirmation when initiating a call in a large group
  • The PR Description

    • As a Wire user, I would like to see a confirmation screen when calling a large group so that I do not disturb a large group of people inadvertently

References
  1. https://wearezeta.atlassian.net/browse/SQSERVICES-1923

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #15182 (d7e805f) into dev (20b50f7) will increase coverage by 0.01%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##              dev   #15182      +/-   ##
==========================================
+ Coverage   43.20%   43.21%   +0.01%     
==========================================
  Files         644      644              
  Lines       21656    21659       +3     
  Branches     4959     4961       +2     
==========================================
+ Hits         9357     9361       +4     
+ Misses      11106    11105       -1     
  Partials     1193     1193              

@arjita-mitra arjita-mitra merged commit e1e9aa2 into dev May 15, 2023
@arjita-mitra arjita-mitra deleted the feature/SQSERVICES-1923 branch May 15, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants