Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display warning for failure to send a message to an offline back-end [FS-1989] #15231

Merged
merged 12 commits into from
May 30, 2023
Merged

feat: display warning for failure to send a message to an offline back-end [FS-1989] #15231

merged 12 commits into from
May 30, 2023

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented May 24, 2023 •
edited by github-actions bot
Loading

BugFS-1989 [Web] Learn more link is missing from "Message could not be sent, as the backend of domain could not be reached."

Issues

  • A specific error message for a complete failure to send when the recipient b-e is offline wasn't implemented
    image

  • A link to the help center is missing in a couple places

@codecov
Copy link

codecov bot commented May 24, 2023 •
edited
Loading

Codecov Report

Merging #15231 (4cd1cb3) into dev (3bed0b8) will decrease coverage by 0.02%.
The diff coverage is 45.00%.

@@            Coverage Diff             @@
##              dev   #15231      +/-   ##
==========================================
- Coverage   43.23%   43.22%   -0.02%     
==========================================
  Files         646      646              
  Lines       21731    21750      +19     
  Branches     4985     4992       +7     
==========================================
+ Hits         9396     9401       +5     
- Misses      11137    11150      +13     
- Partials     1198     1199       +1

@V-Gira V-Gira marked this pull request as ready for review May 30, 2023 07:25
@V-Gira V-Gira requested review from a team and otto-the-bot as code owners May 30, 2023 07:25
@V-Gira V-Gira merged commit b216ea9 into dev May 30, 2023
@V-Gira V-Gira deleted the virgile/learn-more branch May 30, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykBuniX PatrykBuniX PatrykBuniX approved these changes

@arjita-mitra arjita-mitra arjita-mitra approved these changes

@przemvs przemvs przemvs approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: M type: feature / request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@V-Gira @przemvs @arjita-mitra @PatrykBuniX @otto-the-bot