Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid displaying users without metadata nor messages [WBP-1073] #15319

Merged
merged 10 commits into from
Jun 12, 2023

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Jun 8, 2023

Issue

  • 1 on 1 conversations with users without metadata or messages still appear if the conversation is hosted on the selfuser b-e

Solution

  • speciffically filter out conversations with users without metadata that do not have messages from the visible Conversations state

Additional steps

  • the messages array isn't kept in memory outside active conversations, we added a hasContentMessages KO observable to conversation state to keep track of conversation with messages
  • conversations were filtered for established mls conversations at the component level (and missing from the group folder component), refactored to the ConversationsState level

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #15319 (ed9124f) into dev (78763ef) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##              dev   #15319   +/-   ##
=======================================
  Coverage   43.18%   43.19%           
=======================================
  Files         647      647           
  Lines       21775    21779    +4     
  Branches     5004     5006    +2     
=======================================
+ Hits         9404     9407    +3     
- Misses      11167    11168    +1     
  Partials     1204     1204           

@V-Gira V-Gira marked this pull request as ready for review June 12, 2023 13:01
@V-Gira V-Gira requested review from a team and otto-the-bot as code owners June 12, 2023 13:01
@V-Gira V-Gira merged commit d8427fa into dev Jun 12, 2023
@V-Gira V-Gira deleted the virgile/1-on-1-without-metatdatas branch June 12, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants