fix: handle failure to send mls messages (WPB-2300) #15369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-Gira
commented
Jun 20, 2023
Comment on lines
-812
to
+811
| if (isBackendError(error)) { | ||
| await this.updateMessageAsFailed(conversation, payload.messageId, error); | ||
| } | ||
| await this.updateMessageAsFailed(conversation, payload.messageId, error); |
There was a problem hiding this comment.
I could alternatively check for Axios errors with isAxiosError(error) but I think we would want to treat any error as a failure to send with the option to retry
Codecov Report
@@ Coverage Diff @@
## dev #15369 +/- ##
==========================================
- Coverage 43.21% 43.21% -0.01%
==========================================
Files 647 647
Lines 21784 21782 -2
Branches 5006 5004 -2
==========================================
- Hits 9415 9414 -1
+ Misses 11165 11164 -1
Partials 1204 1204 |
PatrykBuniX
reviewed
Jun 20, 2023
| @@ -1187,7 +1184,7 @@ export class MessageRepository { | |||
| return undefined; | |||
| } | |||
|
|
|||
| private async updateMessageAsFailed(conversationEntity: Conversation, eventId: string, error: BackendError) { | |||
| private async updateMessageAsFailed(conversationEntity: Conversation, eventId: string, error: BackendError | any) { | |||
There was a problem hiding this comment.
Can't we go with just unknown and check what type of error it is inside the method?
There was a problem hiding this comment.
like this?
if (isBackendError(error) && error.label === BackendErrorLabel.FEDERATION_REMOTE_ERROR)
PatrykBuniX
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
when sending a message to an mls conversation, the option to retry do not appear when the owning b-e is offline
same thing when sending a message while internet is offline using api v4
wrong styling in some cases
Solutions
bump core to 40.5.4, see fix: handle error when sending mls message [WBP-2300] wire-web-packages#5254
handle
AxiosErroras failure to sendmake sure error messages appear in red, and unsent messages gray