feat: Add ping confirmation modal (WPB-3202) #15380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15380 +/- ##
==========================================
+ Coverage 43.21% 43.42% +0.21%
==========================================
Files 647 649 +2
Lines 21790 22082 +292
Branches 5003 5050 +47
==========================================
+ Hits 9417 9590 +173
- Misses 11169 11259 +90
- Partials 1204 1233 +29 |
|
i guess this is waiting for Design, product, etc. if there is a ticket in jira please link it to this. |
thisisamir98
changed the title
|
we have a ticket now: WPB-3202 |
PatrykBuniX
reviewed
Jul 18, 2023
| window.setTimeout(() => setIsPingDisabled(false), CONFIG.PING_TIMEOUT); | ||
| }); | ||
| if (conversationEntity.is1to1() || totalConversationUsers < 3) { | ||
| setIsPingDisabled(true); |
There was a problem hiding this comment.
Seems like setIsPingDisabled(true); could be part of ping function, no?
PatrykBuniX
reviewed
Jul 18, 2023
Comment on lines
585
to
588
| action: () => { | ||
| setIsPingDisabled(true); | ||
| ping(); | ||
| }, |
There was a problem hiding this comment.
After setIsPingDisabled(true); is moved to ping, we can simplify this part to just:
{
action: ping,
}
PatrykBuniX
reviewed
Jul 18, 2023
| messageRepository.sendPing(conversationEntity).then(() => { | ||
| window.setTimeout(() => setIsPingDisabled(false), CONFIG.PING_TIMEOUT); | ||
| }); | ||
| if (conversationEntity.is1to1() || totalConversationUsers < 3) { |
There was a problem hiding this comment.
What about having a constant for this "3"? e.g. MAX_USERS_TO_PING_WITHOUT_ALERT?
arjita-mitra
approved these changes
Jul 18, 2023
przemvs
reviewed
Jul 18, 2023
przemvs
reviewed
Jul 18, 2023
przemvs
reviewed
Jul 18, 2023
przemvs
reviewed
Jul 18, 2023
PatrykBuniX
approved these changes
Jul 18, 2023
przemvs
reviewed
Jul 18, 2023
przemvs
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.