feat: allow mobile oauth/calendar access [WPB-1524] #15453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15453 +/- ##
==========================================
+ Coverage 43.32% 43.43% +0.11%
==========================================
Files 647 649 +2
Lines 21831 22091 +260
Branches 5018 5053 +35
==========================================
+ Hits 9458 9596 +138
- Misses 11154 11262 +108
- Partials 1219 1233 +14 |
tlebon
force-pushed
the
feat/mobile-oauth
branch
from
aaabcb0
to
bc269f2
Compare
tlebon
changed the title
tlebon
commented
Jul 13, 2023
Comment on lines
-124
to
-132
| useEffect(() => { | ||
| const isEnabled = | ||
| Config.getConfig().URL.MOBILE_BASE && UrlUtil.hasURLParameter(QUERY_KEY.PWA_AWARE) && isPwaSupportedBrowser(); | ||
| setIsPwaEnabled(isEnabled); | ||
| if (isEnabled) { | ||
| setForceNewTemporaryGuestAccount(true); | ||
| } | ||
| }, []); | ||
|
|
There was a problem hiding this comment.
also cleaned out some unused PWA junk
PatrykBuniX
reviewed
Jul 21, 2023
PatrykBuniX
reviewed
Jul 21, 2023
tlebon
force-pushed
the
feat/mobile-oauth
branch
from
1cf62d5
to
2844aab
Compare
przemvs
reviewed
Jul 21, 2023
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik@wire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
allows access to the mobile login flow for mobile devices only during oauth
Causes (Optional)
mobile browser is blocked for all cases currently. should be allowed in this specific case.
Solutions
allow mobile browser in the runtimeAction, improve some stylign.
Testing
How to Test
currently testable with mobile devices @ https://wire-webapp-qa.zinfra.io/auth?client_id=e30a9b94-8e0d-4b15-8a1a-236f68729cdd&redirect_uri=https%3A%2F%2Foutlook.integrations.zinfra.io%2Fcallback.html&response_type=code&state=059fd6946227cec2&scope=write%3Aconversations+write%3Aconversations_code+read%3Aself+read%3Afeature_configs&code_challenge_method=S256&code_challenge=4iV76XHRmPw-bIO5B0io4_F2ittdwd0EULIZ3T-LMU0#/authorize