Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reveal button for the password field #15603

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

arjita-mitra
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • use ui-kit Input component
    • remove unused style code
  • The PR Description

    • add password reveal button
    • add help text for password

What's new in this PR?

Issues

  • without password reveal button when browser autocomplete password field its difficult for the user to know if correct password was filled.

Solutions

  • use password reveal button

References
  1. https://wearezeta.atlassian.net/browse/WPB-3654x

use ui-kit Input component
remove unused code
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #15603 (0c06a74) into dev (018fc98) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev   #15603   +/-   ##
=======================================
  Coverage   43.56%   43.56%           
=======================================
  Files         653      653           
  Lines       22253    22253           
  Branches     5089     5089           
=======================================
  Hits         9694     9694           
  Misses      11315    11315           
  Partials     1244     1244           

@arjita-mitra arjita-mitra merged commit ec5d18f into dev Aug 15, 2023
11 checks passed
@arjita-mitra arjita-mitra deleted the improvement/WPB-3654 branch August 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants