Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new conversation opening using keyboard is not focusing on the last message #15681

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

arjita-mitra
Copy link
Contributor

…ing a conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • New conversation opening using keyboard is not focusing on the last message
  • The PR Description

    • New conversation opening using keyboard should focusing on the last message.

What's new in this PR?

Issues

  • New conversation opening using keyboard is not focusing on the last message. The issue was introduced in this PR

Solutions

  • pass current history state when calling setHistoryParam from showConversation method

Testing

How to Test

  • unit tests added
  • open a new conversation by clicking enter from the left panel->the last message of that conversation should get focused.

PR Post Submission Checklist for internal contributors (Optional)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #15681 (cd57403) into dev (45e714b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev   #15681   +/-   ##
=======================================
  Coverage   43.81%   43.82%           
=======================================
  Files         672      672           
  Lines       22684    22686    +2     
  Branches     5160     5161    +1     
=======================================
+ Hits         9940     9942    +2     
  Misses      11494    11494           
  Partials     1250     1250           

@arjita-mitra arjita-mitra merged commit 9cbc407 into dev Aug 29, 2023
11 checks passed
@arjita-mitra arjita-mitra deleted the bugfix/message-focus branch August 29, 2023 10:59
arjita-mitra added a commit that referenced this pull request Aug 29, 2023
…ast message (#15681)

* fix: pass current history state while calling history param when showing a conversation

* test: add tests
arjita-mitra added a commit that referenced this pull request Aug 29, 2023
…ast message (#15681)

* fix: pass current history state while calling history param when showing a conversation

* test: add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants