Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve AccountPreferences types #15777

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Sep 11, 2023

Description

Change passing selfUser props for AccountPreferences component. The userState was removed from this component because we don't need it there. Now selfUser is passed from parent component to AccountPreferences so our code doesn't show TS issues.

Screenshots/Screencast (for UI changes)

Before:
image
After:
image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@przemvs przemvs requested review from otto-the-bot and a team as code owners September 11, 2023 08:34
@przemvs przemvs changed the title fix: AccountPreferences component chore: AccountPreferences component Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #15777 (793a02c) into dev (a8ed7d8) will increase coverage by 0.00%.
The diff coverage is 18.18%.

@@           Coverage Diff           @@
##              dev   #15777   +/-   ##
=======================================
  Coverage   44.48%   44.48%           
=======================================
  Files         672      672           
  Lines       22706    22707    +1     
  Branches     5168     5168           
=======================================
+ Hits        10100    10101    +1     
  Misses      11317    11317           
  Partials     1289     1289           

@atomrc atomrc changed the title chore: AccountPreferences component chore: improve AccountPreferences types Sep 11, 2023
@przemvs przemvs merged commit 17d3f6e into dev Sep 11, 2023
23 checks passed
@przemvs przemvs deleted the bugfix/account-preferences branch September 11, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants