Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reevaluate supported protocols on client delete #15840

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

PatrykBuniX
Copy link
Contributor

Description

Re-evaluate the list of supported protocols every time one of self user's client is deleted.

For user to add "mls" to the list of their supported protocols, all of their active (last_active <= 4 weeks) clients must be mls-capable devices. User might want to delete their old proteus devices, not to wait for those 4 weeks to pass. We need to reevaluate the list of supported protocols every time their client gets deleted, so:

  • every time user deletes some other client themselves using current client
  • every time user receives an event from backend about their client being deleted.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #15840 (6056c3b) into dev (1fda360) will increase coverage by 0.03%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##              dev   #15840      +/-   ##
==========================================
+ Coverage   44.48%   44.52%   +0.03%     
==========================================
  Files         673      673              
  Lines       22717    22725       +8     
  Branches     5166     5167       +1     
==========================================
+ Hits        10106    10118      +12     
+ Misses      11323    11317       -6     
- Partials     1288     1290       +2     

@PatrykBuniX PatrykBuniX force-pushed the feat/reevaluate-supported-protocols-on-client-delete branch from 152cce6 to 6056c3b Compare September 18, 2023 11:26
@PatrykBuniX PatrykBuniX marked this pull request as ready for review September 18, 2023 11:45
@PatrykBuniX PatrykBuniX merged commit 95c49f0 into dev Sep 18, 2023
11 checks passed
@PatrykBuniX PatrykBuniX deleted the feat/reevaluate-supported-protocols-on-client-delete branch September 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants