Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow member join/leave events to also show unread count badge [WPB-5148] #16085

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Oct 23, 2023

BugWPB-5148 [web] unread count disapears when a member message arrives in a conversation

Description

Screenshots/Screencast (for UI changes)

Before

no-unread.mp4

After

Screen.Recording.2023-10-23.at.10.55.41.mov

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #16085 (c4b4e31) into dev (154c054) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev   #16085   +/-   ##
=======================================
  Coverage   44.81%   44.82%           
=======================================
  Files         706      706           
  Lines       23331    23328    -3     
  Branches     5301     5299    -2     
=======================================
  Hits        10456    10456           
+ Misses      11518    11515    -3     
  Partials     1357     1357           

@atomrc atomrc merged commit 2da3868 into dev Oct 23, 2023
15 checks passed
@atomrc atomrc deleted the fix/member-event-unread branch October 23, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants