feat: Sort user reactions chronologically [WPB-4253] #16101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Oct 24, 2023
| @@ -188,7 +189,7 @@ export class EventMapper { | |||
| } | |||
|
|
|||
| if (event.reactions) { | |||
| originalEntity.reactions(event.reactions); | |||
| originalEntity.reactions(userReactionMapToReactionMap(event.reactions)); | |||
There was a problem hiding this comment.
mapping the reactions to the new format (making sure the old format is never lying around in the app state)
atomrc
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #16101 +/- ##
==========================================
- Coverage 44.79% 44.77% -0.02%
==========================================
Files 708 709 +1
Lines 23290 23232 -58
Branches 5287 5278 -9
==========================================
- Hits 10433 10403 -30
+ Misses 11497 11470 -27
+ Partials 1360 1359 -1 |
atomrc
force-pushed
the
feat/sorted-user-reactions
branch
from
ff63a5e
to
afe6391
Compare
atomrc
force-pushed
the
feat/sorted-user-reactions
branch
from
afe6391
to
7dd3075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were, previously, storing reactions as a map of
Record<userId, reactions>. Which means that the order of the reactions received is lost.This PR changes the format in which the reactions are stored to an array of tuples
[reaction, userIds]. This way, reactions are sorted chronologically.Screenshots/Screencast (for UI changes)
Before
Screen.Recording.2023-10-24.at.12.28.09.mov
After
Screen.Recording.2023-10-24.at.12.27.50.mov
Checklist