-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Conversation details of archived conversation still show 'Archive' option #16128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #16128 +/- ##
==========================================
- Coverage 44.54% 44.52% -0.02%
==========================================
Files 708 708
Lines 23151 23160 +9
Branches 5259 5261 +2
==========================================
Hits 10313 10313
- Misses 11498 11507 +9
Partials 1340 1340 |
atomrc
reviewed
Oct 30, 2023
atomrc
reviewed
Oct 30, 2023
atomrc
reviewed
Oct 30, 2023
atomrc
reviewed
Oct 30, 2023
src/script/page/RightSidebar/ConversationDetails/utils/getConversationActions.ts
Outdated
Show resolved
Hide resolved
atomrc
approved these changes
Oct 30, 2023
…ersationActions.ts Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
echoes-hq
bot
added
the
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
label
Aug 14, 2024
echoes-hq
bot
removed
the
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
label
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conversation details of an archived conversation still show 'Archive' option. When a conversation is archived, the conversation details should show unarchive option. If user tries to unarchive a conversation then first we should unarchive the conversation then check if that was the last archived conversation if yes we need to switch the view to conversation list otherwise stay in the archived view.
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)