Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conversation details of archived conversation still show 'Archive' option #16128

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

arjita-mitra
Copy link
Contributor

Description

Conversation details of an archived conversation still show 'Archive' option. When a conversation is archived, the conversation details should show unarchive option. If user tries to unarchive a conversation then first we should unarchive the conversation then check if that was the last archived conversation if yes we need to switch the view to conversation list otherwise stay in the archived view.

Screenshots/Screencast (for UI changes)

Screenshot 2023-10-30 at 13 41 46 Screenshot 2023-10-30 at 13 41 03

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • Need to update the unarchived icon.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #16128 (5cbeb97) into dev (a929ff6) will decrease coverage by 0.02%.
Report is 2 commits behind head on dev.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #16128      +/-   ##
==========================================
- Coverage   44.54%   44.52%   -0.02%     
==========================================
  Files         708      708              
  Lines       23151    23160       +9     
  Branches     5259     5261       +2     
==========================================
  Hits        10313    10313              
- Misses      11498    11507       +9     
  Partials     1340     1340              

arjita-mitra and others added 2 commits October 30, 2023 17:09
…ersationActions.ts

Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
@arjita-mitra arjita-mitra merged commit 50b77fc into dev Nov 6, 2023
13 checks passed
@arjita-mitra arjita-mitra deleted the bugfix/WPB-5166 branch November 6, 2023 10:30
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
@echoes-hq echoes-hq bot removed the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants