-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Group messages in the chat by user and timestamp #16496
Merged
przemvs
merged 14 commits into
feat/WPB-5852-message-content-width
from
feat/WPB-3072-group-messages-in-the-chat-by-user-and-timestamp
Jan 22, 2024
Merged
feat: Group messages in the chat by user and timestamp #16496
przemvs
merged 14 commits into
feat/WPB-5852-message-content-width
from
feat/WPB-3072-group-messages-in-the-chat-by-user-and-timestamp
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/WPB-5852-message-content-width #16496 +/- ##
=======================================================================
- Coverage 45.42% 45.41% -0.01%
=======================================================================
Files 740 742 +2
Lines 24240 24272 +32
Branches 5506 5524 +18
=======================================================================
+ Hits 11010 11024 +14
- Misses 11822 11835 +13
- Partials 1408 1413 +5 |
…ser-and-timestamp
…ser-and-timestamp
…ser-and-timestamp
…ser-and-timestamp
…ser-and-timestamp
…ser-and-timestamp
…ser-and-timestamp
przemvs
changed the base branch from
dev
to
feat/WPB-5852-message-content-width
January 19, 2024 11:18
…-group-messages-in-the-chat-by-user-and-timestamp
This should be merged after code freeze. |
aweiss-dev
approved these changes
Jan 19, 2024
przemvs
merged commit Jan 22, 2024
b8f359d
into
feat/WPB-5852-message-content-width
10 checks passed
przemvs
deleted the
feat/WPB-3072-group-messages-in-the-chat-by-user-and-timestamp
branch
January 22, 2024 09:19
przemvs
added a commit
that referenced
this pull request
Jan 22, 2024
* feat: Message content width * feat: Group messages in the chat by user and timestamp (#16496) * feat: Group messages in the chat by user and timestamp * feat: Prepare new version * improve message asset read indicator * revert opacity to 0 for not hovered message * revert expectsReadConfirmation * clear unecessary styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Group messages in the chat by user and timestamp. Previous we displaying message in row, now we grouping messages by timestamp.
Examples
3 messages sent by John Smith shortly after each other, at 10:32 a.m. are grouped by the same message header and the timestamp “10:32 a.m.”
A 4th message sent by John Smith at 10:33 a.m. is displayed by another message header with the timestamp “10:33 a.m.”
Screenshots/Screencast (for UI changes)
Previous:
Now:
Additional information:
This case is hard to debug in browser, so will be fixed ASAP after merge this task.
Checklist
Important details for the reviewers
(Delete this section if unnecessary)