Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Group messages in the chat by user and timestamp #16496

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Jan 9, 2024

Description

Group messages in the chat by user and timestamp. Previous we displaying message in row, now we grouping messages by timestamp.

Examples

3 messages sent by John Smith shortly after each other, at 10:32 a.m. are grouped by the same message header and the timestamp “10:32 a.m.”

A 4th message sent by John Smith at 10:33 a.m. is displayed by another message header with the timestamp “10:33 a.m.”

Screenshots/Screencast (for UI changes)

Previous:
image

Now:
image

image

Additional information:
image

This case is hard to debug in browser, so will be fixed ASAP after merge this task.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (3e5cc60) 45.42% compared to head (0461f70) 45.41%.

❗ Current head 0461f70 differs from pull request most recent head 7c4a961. Consider uploading reports for the commit 7c4a961 to get more accurate results

Additional details and impacted files
@@                           Coverage Diff                           @@
##           feat/WPB-5852-message-content-width   #16496      +/-   ##
=======================================================================
- Coverage                                45.42%   45.41%   -0.01%     
=======================================================================
  Files                                      740      742       +2     
  Lines                                    24240    24272      +32     
  Branches                                  5506     5524      +18     
=======================================================================
+ Hits                                     11010    11024      +14     
- Misses                                   11822    11835      +13     
- Partials                                  1408     1413       +5     

@przemvs przemvs changed the base branch from dev to feat/WPB-5852-message-content-width January 19, 2024 11:18
…-group-messages-in-the-chat-by-user-and-timestamp
@przemvs
Copy link
Contributor Author

przemvs commented Jan 19, 2024

This should be merged after code freeze.

@przemvs przemvs merged commit b8f359d into feat/WPB-5852-message-content-width Jan 22, 2024
10 checks passed
@przemvs przemvs deleted the feat/WPB-3072-group-messages-in-the-chat-by-user-and-timestamp branch January 22, 2024 09:19
przemvs added a commit that referenced this pull request Jan 22, 2024
* feat: Message content width

* feat: Group messages in the chat by user and timestamp (#16496)

* feat: Group messages in the chat by user and timestamp

* feat: Prepare new version

* improve message asset read indicator

* revert opacity to 0 for not hovered message

* revert expectsReadConfirmation

* clear unecessary styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants