feat: show read receipt in message header (WPB-6284) #16851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #16851 +/- ##
=======================================
Coverage 45.97% 45.97%
=======================================
Files 748 748
Lines 24494 24496 +2
Branches 5592 5593 +1
=======================================
+ Hits 11262 11263 +1
Misses 11807 11807
- Partials 1425 1426 +1 |
V-Gira
force-pushed
the
v/header-read-receipt
branch
from
bbdae3e
to
c1686d5
Compare
V-Gira
commented
Feb 26, 2024
Comment on lines
+183
to
+188
| <ReadIndicator | ||
| message={lastMessageInGroup} | ||
| is1to1Conversation={conversation.is1to1()} | ||
| isLastDeliveredMessage={isLastDeliveredMessage || lastMessageInGroup.status() === StatusType.DELIVERED} | ||
| showIconOnly | ||
| /> |
There was a problem hiding this comment.
Instead of the message directly after the header, we pass the last message in the group to the read indicator.
V-Gira
added a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A non clickeable read receipt is added after the message header (username + timestamp)
It reflects the status of the last message in the group
Screenshots/Screencast (for UI changes)
1on1:
Group:
Checklist