Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update padding and font size for CodeBlock #16954

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Feb 29, 2024

Description

Screenshots/Screencast (for UI changes)

Before:
image

After:
image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.07%. Comparing base (16f2977) to head (780b7f6).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16954      +/-   ##
==========================================
- Coverage   46.08%   46.07%   -0.01%     
==========================================
  Files         746      746              
  Lines       24414    24414              
  Branches     5588     5588              
==========================================
- Hits        11250    11249       -1     
  Misses      11745    11745              
- Partials     1419     1420       +1     

border-radius: 12px;
background: var(--foreground-fade-8);
font-size: 12px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: 12px;
font-size: var(--font-size-small)

missed that before apparently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@przemvs przemvs merged commit ed58458 into dev Feb 29, 2024
11 checks passed
@przemvs przemvs deleted the fix/change-code-block-padding-and-font-size branch February 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants