-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve link preview image display #17100
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17100 +/- ##
=======================================
Coverage 46.15% 46.15%
=======================================
Files 747 747
Lines 24548 24548
Branches 5610 5610
=======================================
Hits 11329 11329
Misses 11786 11786
Partials 1433 1433 |
@@ -32,7 +32,8 @@ | |||
} | |||
|
|||
.link-preview-image-container { | |||
width: @link-preview-height; | |||
min-width: @link-preview-height; | |||
height: @link-preview-height; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the variable to rem, the reason height wasn't fixed was for larger font sizes.
80px would be 5rem, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's why we had this strange : width: @...-height
:D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using rem sounds like a nice solution 👍
6264890
to
329767c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how that looks :)
@@ -18,7 +18,7 @@ | |||
*/ | |||
|
|||
// variables | |||
@link-preview-height: 88px; | |||
@link-preview-height: 5.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I read 80px for some reason, good on ya for double checking :D
Description
Screenshots/Screencast (for UI changes)
Before
After
Checklist