chore: cherry-pick MLS 1:1 conversation over SFT to dev [WPB-10120] #18066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
echoes: bugs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18066 +/- ##
==========================================
- Coverage 51.11% 51.06% -0.06%
==========================================
Files 794 794
Lines 25529 25561 +32
Branches 5835 5842 +7
==========================================
+ Hits 13050 13052 +2
- Misses 12103 12134 +31
+ Partials 376 375 -1 |
V-Gira
changed the title
echoes-hq
bot
added
the
echoes/initiative: federation-wire-cloud
przemvs
reviewed
Sep 20, 2024
Comment on lines
1074
to
1084
| private readonly leave1on1MLSConference = async (conversationId: QualifiedId) => { | ||
| await this.subconversationService.leaveConferenceSubconversation(conversationId); | ||
|
|
||
| const conversationIdStr = this.serializeQualifiedId(conversationId); | ||
| this.wCall?.end(this.wUser, conversationIdStr); | ||
| callingSubscriptions.removeCall(conversationId); | ||
| }; |
There was a problem hiding this comment.
There is missing countly part ;)
przemvs
reviewed
Sep 20, 2024
|
* runfix: use mls conference subconversation for 1:1 calls * chore: feature flag todo * runfix: add env feature flag * runfix: remove feature flag * runfix: conference calls for proteus 1:1 if flag is enabled * docs: add fixme comment * chore: set flag to false for the tests to pass * runfix: use feature flag from backend * refactor: apply cr suggestions * runfix: temporarily hardcode sft for 1:1 flag
* fix: handle leaving a 1:1 call over SFT [WPB-7151] * bump core to the new hotfix version * compare participant with self participant id istead of relying on position in the array
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
V-Gira
force-pushed
the
v/cherrypick-release-to-dev
branch
from
999b487
to
9031282
Compare
|
przemvs
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cherry picks the latest changes to MLS 1:1 conversation that couldn't be merged back to dev until now (waiting for a backend config on the release/q1-2024 environments):
Checklist