Fix gcd to handle PUT requests for JSON protocol #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
wirepair
commented
Mar 28, 2023
•
wirepair
commented
- Updates the JSON protocol to use PUT instead of GET, which has been deprecated
- Update test ci to use latest browser
- Updates chromium protocol.json to 111.0.5563.147
added 5 commits
March 28, 2023 12:47
update test ci
Updates gcdapi and json protocol to use PUT
don't call t.Fatal from non-test go routine
fix type errors
update changelog
wirepair
changed the title
update flakey test and run ci tests in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.