Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib.metadata instead of pkg_resources in python 3.10 and above #1200

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

kit494way
Copy link
Contributor

This PR suppress a deprecation warning.

before:

$ SQLALCHEMY_SILENCE_UBER_WARNING=1 csvsql --query 'SELECT * FROM dummy' examples/dummy.csv
/home/kit494way/projects/csvkit/.venv/lib/python3.10/site-packages/pkg_resources/__init__.py:121: DeprecationWarning: pkg_resources is deprecated as an API
a,b,c
1,2.0,3.0

after:

$ SQLALCHEMY_SILENCE_UBER_WARNING=1 csvsql --query 'SELECT * FROM dummy' examples/dummy.csv
a,b,c
1,2.0,3.0

@github-actions
Copy link

Coverage Status

coverage: 88.319% (-0.1%) from 88.421% when pulling 53a4abc on kit494way:csvsql-dialects into 05e9d1b on wireservice:master.

@coveralls
Copy link

Coverage Status

coverage: 88.443% (+0.02%) from 88.421% when pulling 53a4abc on kit494way:csvsql-dialects into 05e9d1b on wireservice:master.

@jpmckinney
Copy link
Member

Thank you!

@jpmckinney jpmckinney merged commit fa7d831 into wireservice:master Jul 20, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants