Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes: default wss endpoint, dependencies upgrade and futures general endpoint ping #219

Merged
merged 3 commits into from
Dec 3, 2023

Conversation

ytskuh
Copy link
Contributor

@ytskuh ytskuh commented Jul 22, 2023

  1. The wss endpoint with 9443 port seems to have issue according to websocket receive MarketData error #123. By simply adjusting the default endpoint the problem can be fixed.
  2. The mock module has deprecated since mockito 1.0.0. Upgraded the dependencies and affected test module. Some other dependencies are also safely upgraded.
  3. FuturesGeneral::ping() doesn't work and since there lacks a test for that, this issue has not been discovered. Added a test module for that and fixed the function.

I'm a Rust beginner and tried my best to make this little contribution.

@ytskuh ytskuh changed the title Some minor fixes Some minor fixes: default wss endpoint, dependencies upgrade and futures general endpoint ping Jul 22, 2023
@wisespace-io wisespace-io merged commit 3017e13 into wisespace-io:master Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants