Cloudflare v10 + Solid breaks some components and scripts #224

MehrdadKhnzd · 2024-04-06T04:24:18Z

Astro Info

Astro                    v4.5.16
Node                     v20.12.0
System                   Linux (x64)
Package Manager          bun
Output                   server
Adapter                  @astrojs/cloudflare
Integrations             unocss
                         @astrojs/solid-js
                         @swup/astro
                         @vite-pwa/astro-integration

Describe the Bug

When I deployed my web app using the new Cloudflare adapter, the functionality of many components and pages became broken.

For many components, it acts like I haven't added client:load at all - just rendering the component in a static form without having any functionality. Surprisingly, it worked for a few others. I'm still not sure about the exact situation causing it.

Also, it doesn't render the pages that have onMount in them. It just outputs blank.

What's the expected result?

All of them should work properly. In the minimal reproduction, you can see how using onMount makes the rendering blank. You can also comment onMount on the Btn.tsx component to see how it renders. I still don't have a concrete example of when the component becomes static and doesn't do anything, but I will add it here if I can.

Link to Minimal Reproducible Example

https://stackblitz.com/~/github.com/MehrdadKhnzd/astro-bug-reproduction

Participation

I am willing to submit a pull request for this issue.

The text was updated successfully, but these errors were encountered:

alexanderniebuhr · 2024-04-06T05:18:18Z

@MehrdadKhnzd Thank you trying to reproduce everything, could you update the permissions on the repo, I can't open it.

MehrdadKhnzd · 2024-04-06T09:10:25Z

Sorry, I fixed the permissions.

alexanderniebuhr · 2024-04-06T18:42:14Z

@MehrdadKhnzd Please try @astrojs/cloudflare@0.0.0-cf-deps-chunk-20240406183753 and let me know if that fixes the client:load issue. It does not fix the onMount issue, but I wonder if it fixes the issue you have with some Solid components

MehrdadKhnzd · 2024-04-07T04:09:24Z

@alexanderniebuhr Now the build fails, both locally and on Cloudflare.
Cannot access 'escape' before initialization

alexanderniebuhr · 2024-04-07T05:35:01Z

@MehrdadKhnzd sorry for that, the build was corrupted.. can you try @astrojs/cloudflare@0.0.0-cf-deps-chunk-20240407053056

MehrdadKhnzd · 2024-04-07T16:48:18Z

@alexanderniebuhr No, it didn't solve any of the problems.

alexanderniebuhr · 2024-04-07T17:07:43Z

Thank you for testing, for now I can only reproduce the onMount issue, we still need a reproduction for the other problems.

deeprobin · 2024-04-11T16:28:16Z

@alexanderniebuhr Now the build fails, both locally and on Cloudflare. Cannot access 'escape' before initialization

I had also this problem in my project.

Now with setting the version to 0.0.0-cf-deps-chunk-20240407053056, I get the following error:

> website@2.0.0 build E:\external\lindner\website
> astro build

18:15:35 [build] output: "server"
18:15:35 [build] directory: E:\external\lindner\website\dist\
18:15:35 [build] adapter: @astrojs/cloudflare
18:15:35 [build] Collecting build info...
18:15:35 [build] ✓ Completed in 340ms.
18:15:35 [build] Building server entrypoints...
18:15:48 [vite] ✓ built in 13.24s
18:15:48 [build] ✓ Completed in 13.32s.

 building client (vite) 
18:15:57 [vite] ✓ 1997 modules transformed.
18:15:57 [vite] dist/_astro/about-us.BNQU8f2g.css      0.39 kB │ gzip:  0.24 kB
18:15:57 [vite] dist/_astro/client.DRtjQ90i.js         0.86 kB │ gzip:  0.54 kB
18:15:57 [vite] dist/_astro/page.55INgWwS.js           2.24 kB │ gzip:  0.99 kB
18:15:57 [vite] dist/_astro/web.CSO6jSne.js           22.06 kB │ gzip:  8.64 kB
18:15:57 [vite] dist/_astro/ThemeToggle.CzAn_00l.js   22.39 kB │ gzip:  9.25 kB
18:15:57 [vite] dist/_astro/hoisted.CFb6nfp3.js      102.47 kB │ gzip: 33.89 kB
18:15:57 [vite] ✓ built in 9.23s
self is not defined
  Stack trace:
    at file:///E:/external/lindner/website/dist/_worker.js/chunks/vendor_eOrI-n3z.mjs:9635:38
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async BuildPipeline.retrieveManifest (file:///E:/external/lindner/website/node_modules/.pnpm/astro@4.6.0_sass@1.74.1_typescript@4.9.5/node_modules/astro/dist/core/build/pipeline.js:83:26)
    at async staticBuild (file:///E:/external/lindner/website/node_modules/.pnpm/astro@4.6.0_sass@1.74.1_typescript@4.9.5/node_modules/astro/dist/core/build/static-build.js:103:7)
    at async AstroBuilder.run (file:///E:/external/lindner/website/node_modules/.pnpm/astro@4.6.0_sass@1.74.1_typescript@4.9.5/node_modules/astro/dist/core/build/index.js:165:7)
    at async build (file:///E:/external/lindner/website/node_modules/.pnpm/astro@4.6.0_sass@1.74.1_typescript@4.9.5/node_modules/astro/dist/cli/build/index.js:20:3)
    at async cli (file:///E:/external/lindner/website/node_modules/.pnpm/astro@4.6.0_sass@1.74.1_typescript@4.9.5/node_modules/astro/dist/cli/index.js:169:5)
 ELIFECYCLE  Command failed with exit code 1.

Repro: https://github.com/lindner-development/website/tree/improvements

alexanderniebuhr · 2024-04-11T18:52:41Z

Thanks for adding context, we're trying to find a fix. This is probably also upstream caused, so we need to make sure we fix it at the right place.

rasco · 2024-04-12T10:51:14Z

not sure if this is related:
#209 (comment)

going back to 9.2.1 resolves the issue

deeprobin · 2024-04-12T15:01:43Z

not sure if this is related: #209 (comment)

going back to 9.2.1 resolves the issue

Yeah that was my initial error, but that got solved using the next minor versions. Now I get this build time error.

deeprobin · 2024-04-18T04:57:32Z

@alexanderniebuhr Do you have any update on this?

alexanderniebuhr · 2024-04-18T05:42:36Z

We're still working on investigation, I also marked this issue as upstream, because we most likely need to fix it in core. However we're trying to find a workaround.

deeprobin · 2024-05-03T07:11:16Z

@alexanderniebuhr

Have there been any clues in the meantime as to how the problem could be fixed?
I would really like to be able to use the integration again - I would only consider downgrading my site to v9 as a last resort.

We're still working on investigation, I also marked this issue as upstream, because we most likely need to fix it in core. However we're trying to find a workaround.

What seems to be the problem in the core?

alexanderniebuhr · 2024-05-03T10:20:23Z

There are some workarounds in all the related issues. I didn't find a solution to ship by default, but this is high priority.

The issue in core is that the generated code gets modified at the end, which leads to imports which don't exist after that modification.

alexanderniebuhr · 2024-05-08T12:49:25Z

@deeprobin @MehrdadKhnzd sorry that this is still not fixed, I'm taking another try at this. Can you please try this version: @astrojs/cloudflare@0.0.0-cf-deps-chunk-20240508124857

Does this fix all the issues you are seeing with Solid?

MehrdadKhnzd · 2024-05-10T13:22:45Z

@alexanderniebuhr Thanks for trying. None of the issues are resolved.

alexanderniebuhr · 2024-05-10T13:25:39Z

Strange, I can't reproduce them anymore, we keep trying

deeprobin · 2024-05-12T07:54:05Z

@alexanderniebuhr I tested the version also.
Now I get no build errors anymore, but I can't test if everything works.
It doesn't like the contentful integration, because it uses somewhere under the hood the eval function.

So first of all I need to find another headless CMS.

alexanderniebuhr · 2024-05-17T09:14:18Z

I think I found the upstream issue: solidjs/vite-plugin-solid#153
This should be fixed in solid first, I would recommend trying to get someone on their discord to comment on it: https://publint.dev/solid-js@1.8.17

alexanderniebuhr · 2024-06-22T09:14:18Z

I don't expect this to be fixed by v11, but might be worth to try again.

MehrdadKhnzd · 2024-07-15T19:58:34Z

@alexanderniebuhr It's still not fixed, and the bigger problem is that even v8.1.0 no longer works. I made some structural changes in my app, and now when I use v8.1.0, which was the latest working version without breaking routes and Solid.js, it continues to create overlapping routes, preventing deployment on Cloudflare. I'm completely out of options and unable to deploy a new version. I hope you have a solution.

alexanderniebuhr · 2024-07-16T06:57:09Z

This is still an upstream bug, I haven't found a solution to make it work in general. There are some workarounds posted in all the issues here and in the upstream repository, maybe they might help you

MehrdadKhnzd · 2024-07-18T16:42:06Z

Among all the solutions, the only effective method that worked without side effects was patching Solid.js and removing the browser field from package.json in both the root package and all its sub-packages.

jasperteo · 2024-07-26T20:35:46Z

I guess our only hope for a fix can only be done from the Solid side. So far I am relying on the temporary workaround suggested in the upstream issue.

resolve: {
  conditions: ["worker", "webworker"],
  mainFields: ["module"],
}

wkelly17 · 2024-10-08T18:36:57Z

@alexanderniebuhr - Solid 1.9 fixed my errors (deploy Pages site and wrangler preview) based on the fix to package.json in above PR. Anyone else following this want to test if your issues resolve?

deeprobin · 2024-10-08T19:27:25Z

@wkelly17 I have currently the problem, that I use another dependency which uses eval on my site -> so the deployment on CF breaks.
Maybe I can fix that problem this month, so I can test the adapter issue.

N0N4M3BNS · 2024-10-30T16:22:54Z

[ERROR] ReferenceError: Cannot access 'page' before initialization
I have this issues so how to fix it?

"astro": "^4.16.7",
"@astrojs/cloudflare": "^11.2.0",

alexanderniebuhr added pkg: cloudflare needs repro Issue needs a reproduction labels Apr 6, 2024

alexanderniebuhr added - P4: important Violate documented behavior or significantly improves performance (priority) and removed needs repro Issue needs a reproduction labels Apr 6, 2024

alexanderniebuhr added the upstream label Apr 11, 2024

alexanderniebuhr mentioned this issue Apr 11, 2024

test for bug reproduction withastro/astro#10738

Closed

alexanderniebuhr mentioned this issue May 8, 2024

fix(cloudflare): node_modules chunk #226

Merged

This was referenced May 17, 2024

Cloudflare + Solid-js hydration / build errors. #263

Closed

fix(cloudflare): solid ssr #264

Closed

alexanderniebuhr mentioned this issue Jun 2, 2024

Client Side Functionality not working properly in Cloudflare Adapter v10 while using Solidjs #272

Closed

1 task

wkelly17 mentioned this issue Aug 16, 2024

fix!: Remove browser field from package.json solidjs/solid#2255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloudflare v10 + Solid breaks some components and scripts #224

Cloudflare v10 + Solid breaks some components and scripts #224

MehrdadKhnzd commented Apr 6, 2024 •

edited

Loading

alexanderniebuhr commented Apr 6, 2024

MehrdadKhnzd commented Apr 6, 2024

alexanderniebuhr commented Apr 6, 2024

MehrdadKhnzd commented Apr 7, 2024

alexanderniebuhr commented Apr 7, 2024

MehrdadKhnzd commented Apr 7, 2024

alexanderniebuhr commented Apr 7, 2024

deeprobin commented Apr 11, 2024

alexanderniebuhr commented Apr 11, 2024

rasco commented Apr 12, 2024

deeprobin commented Apr 12, 2024

deeprobin commented Apr 18, 2024

alexanderniebuhr commented Apr 18, 2024

deeprobin commented May 3, 2024

alexanderniebuhr commented May 3, 2024

alexanderniebuhr commented May 8, 2024

MehrdadKhnzd commented May 10, 2024

alexanderniebuhr commented May 10, 2024

deeprobin commented May 12, 2024

alexanderniebuhr commented May 17, 2024

alexanderniebuhr commented Jun 22, 2024

MehrdadKhnzd commented Jul 15, 2024

alexanderniebuhr commented Jul 16, 2024

MehrdadKhnzd commented Jul 18, 2024

jasperteo commented Jul 26, 2024

wkelly17 commented Oct 8, 2024

deeprobin commented Oct 8, 2024

N0N4M3BNS commented Oct 30, 2024

Cloudflare v10 + Solid breaks some components and scripts #224

Cloudflare v10 + Solid breaks some components and scripts #224

Comments

MehrdadKhnzd commented Apr 6, 2024 • edited Loading

Astro Info

Describe the Bug

What's the expected result?

Link to Minimal Reproducible Example

Participation

alexanderniebuhr commented Apr 6, 2024

MehrdadKhnzd commented Apr 6, 2024

alexanderniebuhr commented Apr 6, 2024

MehrdadKhnzd commented Apr 7, 2024

alexanderniebuhr commented Apr 7, 2024

MehrdadKhnzd commented Apr 7, 2024

alexanderniebuhr commented Apr 7, 2024

deeprobin commented Apr 11, 2024

alexanderniebuhr commented Apr 11, 2024

rasco commented Apr 12, 2024

deeprobin commented Apr 12, 2024

deeprobin commented Apr 18, 2024

alexanderniebuhr commented Apr 18, 2024

deeprobin commented May 3, 2024

alexanderniebuhr commented May 3, 2024

alexanderniebuhr commented May 8, 2024

MehrdadKhnzd commented May 10, 2024

alexanderniebuhr commented May 10, 2024

deeprobin commented May 12, 2024

alexanderniebuhr commented May 17, 2024

alexanderniebuhr commented Jun 22, 2024

MehrdadKhnzd commented Jul 15, 2024

alexanderniebuhr commented Jul 16, 2024

MehrdadKhnzd commented Jul 18, 2024

jasperteo commented Jul 26, 2024

wkelly17 commented Oct 8, 2024

deeprobin commented Oct 8, 2024

N0N4M3BNS commented Oct 30, 2024

MehrdadKhnzd commented Apr 6, 2024 •

edited

Loading