unused dependency 'sitemap', 'filter' option should return boolean (#…

…3563) * refactor: @astrojs/sitemap does't use 'sitemap' pkg * refactor: 'filter' option should return boolean instead of string * fix: forgotten `pnpm install` * chore: add changeset Co-authored-by: Nate Moore <nate@skypack.dev>
withastro · Jun 10, 2022 · 0980312 · 0980312
1 parent 72587ec
commit 0980312
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/.changeset/nice-zebras-unite.md b/.changeset/nice-zebras-unite.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/sitemap': patch
+---
+
+Remove unused dependency
diff --git a/packages/integrations/sitemap/package.json b/packages/integrations/sitemap/package.json
@@ -27,7 +27,6 @@
     "dev": "astro-scripts dev \"src/**/*.ts\""
   },
   "dependencies": {
-    "sitemap": "^7.1.1"
   },
   "devDependencies": {
     "astro": "workspace:*",

diff --git a/packages/integrations/sitemap/src/index.ts b/packages/integrations/sitemap/src/index.ts
@@ -15,7 +15,7 @@ type SitemapOptions =
 			 * filter: (page) => page !== 'http://example.com/secret-page'
 			 * ```
 			 */
-			filter?(page: string): string;
+			filter?(page: string): boolean;
 
 			/**
 			 * If you have any URL, not rendered by Astro, that you want to include in your sitemap,

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml