Fix astro:build:setup hook updateConfig utility (#7438)

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
withastro · Jun 21, 2023 · 30bb363 · 30bb363
1 parent f275d05
commit 30bb363
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 4 deletions.
diff --git a/.changeset/cyan-vans-clap.md b/.changeset/cyan-vans-clap.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix `astro:build:setup` hook `updateConfig` utility, where the configuration wasn't correctly updated when the hook was fired.
diff --git a/packages/astro/src/core/build/static-build.ts b/packages/astro/src/core/build/static-build.ts
@@ -207,15 +207,15 @@ async function ssrBuild(
 		base: settings.config.base,
 	};
 
-	await runHookBuildSetup({
+	const updatedViteBuildConfig = await runHookBuildSetup({
 		config: settings.config,
 		pages: internals.pagesByComponent,
 		vite: viteBuildConfig,
 		target: 'server',
 		logging: opts.logging,
 	});
 
-	return await vite.build(viteBuildConfig);
+	return await vite.build(updatedViteBuildConfig);
 }
 
 async function clientBuild(

diff --git a/packages/astro/src/integrations/index.ts b/packages/astro/src/integrations/index.ts
@@ -286,7 +286,9 @@ export async function runHookBuildSetup({
 	pages: Map<string, PageBuildData>;
 	target: 'server' | 'client';
 	logging: LogOptions;
-}) {
+}): Promise<InlineConfig> {
+	let updatedConfig = vite;
+
 	for (const integration of config.integrations) {
 		if (integration?.hooks?.['astro:build:setup']) {
 			await withTakingALongTimeMsg({
@@ -296,13 +298,15 @@ export async function runHookBuildSetup({
 					pages,
 					target,
 					updateConfig: (newConfig) => {
-						mergeConfig(vite, newConfig);
+						updatedConfig = mergeConfig(updatedConfig, newConfig);
 					},
 				}),
 				logging,
 			});
 		}
 	}
+
+	return updatedConfig;
 }
 
 export async function runHookBuildSsr({

diff --git a/packages/astro/test/units/integrations/api.test.js b/packages/astro/test/units/integrations/api.test.js
@@ -0,0 +1,30 @@
+import { expect } from 'chai';
+import { runHookBuildSetup } from '../../../dist/integrations/index.js';
+
+describe('Integration API', () => {
+	it('runHookBuildSetup should work', async () => {
+		const updatedViteConfig = await runHookBuildSetup({
+			config: {
+				integrations: [
+					{
+						name: 'test',
+						hooks: {
+							'astro:build:setup'({ updateConfig }) {
+								updateConfig({
+									define: {
+										foo: 'bar',
+									},
+								});
+							},
+						},
+					},
+				],
+			},
+			vite: {},
+			logging: {},
+			pages: new Map(),
+			target: 'server',
+		});
+		expect(updatedViteConfig).to.haveOwnProperty('define');
+	});
+});