Add initial core image tests (#6381)

withastro · Feb 28, 2023 · 406eff6 · 406eff6
1 parent 33238d4
commit 406eff6
Show file tree

Hide file tree

Showing 7 changed files with 162 additions and 0 deletions.
diff --git a/packages/astro/test/core-image.test.js b/packages/astro/test/core-image.test.js
@@ -0,0 +1,108 @@
+import { expect, assert } from 'chai';
+import { loadFixture } from './test-utils.js';
+import * as cheerio from 'cheerio';
+import { Writable } from 'node:stream';
+
+describe('astro:image', () => {
+	/** @type {import('./test-utils').Fixture} */
+	let fixture;
+
+	describe('dev', () => {
+		/** @type {import('./test-utils').DevServer} */
+		let devServer;
+		/** @type {Array<{ type: any, level: 'error', message: string; }>} */
+		let logs = [];
+
+		before(async () => {
+			fixture = await loadFixture({
+				root: './fixtures/core-image/',
+				experimental: {
+					images: true,
+				}
+			});
+
+			devServer = await fixture.startDevServer({
+				logging: {
+					level: 'error',
+					dest: new Writable({
+						objectMode: true,
+						write(event, _, callback) {
+							logs.push(event);
+							callback();
+						}
+					})
+				}
+			});
+		});
+
+		after(async () => {
+			await devServer.stop();
+		});
+
+		describe('basics', () => {
+			let $;
+			before(async() => {
+				let res = await fixture.fetch('/');
+				let html = await res.text();
+				$ = cheerio.load(html);
+			});
+
+			it('Adds the <img> tag', () => {
+				let $img = $('#local img');
+				expect($img).to.have.a.lengthOf(1);
+				expect($img.attr('src').startsWith('/_image')).to.equal(true);
+			});
+
+			it('includes loading and decoding attributes', () => {
+				let $img = $('#local img');
+				expect(!!$img.attr('loading')).to.equal(true);
+				expect(!!$img.attr('decoding')).to.equal(true);
+			});
+
+			it('includes the provided alt', () => {
+				let $img = $('#local img');
+				expect($img.attr('alt')).to.equal('a penguin');
+			});
+		});
+
+		describe('remote', () => {
+			describe('working', () => {
+				let $;
+				before(async () => {
+					let res = await fixture.fetch('/');
+					let html = await res.text();
+					$ = cheerio.load(html);
+				});
+
+				it('includes the provided alt', async () => {
+					let $img = $('#remote img');
+					expect($img.attr('alt')).to.equal('fred');
+				});
+
+				it('includes loading and decoding attributes', () => {
+					let $img = $('#remote img');
+					expect(!!$img.attr('loading')).to.equal(true);
+					expect(!!$img.attr('decoding')).to.equal(true);
+				});
+			});
+
+			it('error if no width and height', async () => {
+				logs.length = 0;
+				let res = await fixture.fetch('/remote-error-no-dimensions');
+				await res.text();
+
+				expect(logs).to.have.a.lengthOf(1);
+				expect(logs[0].message).to.contain('For remote images, width and height are required.');
+			});
+
+			it('error if no height', async () => {
+				logs.length = 0;
+				let res = await fixture.fetch('/remote-error-no-height');
+				await res.text();
+
+				expect(logs).to.have.a.lengthOf(1);
+				expect(logs[0].message).to.contain('For remote images, height is required.');
+			});
+		})
+	});
+});
diff --git a/packages/astro/test/fixtures/core-image/package.json b/packages/astro/test/fixtures/core-image/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@test/core-image",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}
diff --git a/packages/astro/test/fixtures/core-image/src/assets/penguin1.jpg b/packages/astro/test/fixtures/core-image/src/assets/penguin1.jpg
diff --git a/packages/astro/test/fixtures/core-image/src/pages/index.astro b/packages/astro/test/fixtures/core-image/src/pages/index.astro
@@ -0,0 +1,18 @@
+---
+import { Image } from 'astro:assets';
+import myImage from "../assets/penguin1.jpg";
+---
+<html>
+<head>
+
+</head>
+<body>
+	<div id="local">
+		<Image src={myImage} alt="a penguin" />
+	</div>
+
+	<div id="remote">
+		<Image src="https://avatars.githubusercontent.com/u/622227?s=64" alt="fred" width="48" height="48" />
+	</div>
+</body>
+</html>
diff --git a/packages/astro/test/fixtures/core-image/src/pages/remote-error-no-dimensions.astro b/packages/astro/test/fixtures/core-image/src/pages/remote-error-no-dimensions.astro
@@ -0,0 +1,11 @@
+---
+import { Image } from 'astro:assets';
+---
+<html>
+<head>
+
+</head>
+<body>
+	<Image src="https://avatars.githubusercontent.com/u/622227?s=64" alt="fred" />
+</body>
+</html>
diff --git a/packages/astro/test/fixtures/core-image/src/pages/remote-error-no-height.astro b/packages/astro/test/fixtures/core-image/src/pages/remote-error-no-height.astro
@@ -0,0 +1,11 @@
+---
+import { Image } from 'astro:assets';
+---
+<html>
+<head>
+
+</head>
+<body>
+	<Image src="https://avatars.githubusercontent.com/u/622227?s=64" alt="fred" width="48" />
+</body>
+</html>
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml