fix(errors): Remove duplicate logging of errors (#10197)

* fix(errors): Remove duplicate logging of errors * chore: changeset
withastro · Feb 22, 2024 · c856c72 · c856c72
1 parent 598f30c
commit c856c72
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/light-masks-watch.md b/.changeset/light-masks-watch.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes errors being logged twice in some cases
diff --git a/packages/astro/src/vite-plugin-astro-server/response.ts b/packages/astro/src/vite-plugin-astro-server/response.ts
@@ -83,9 +83,8 @@ export async function writeWebResponse(res: http.ServerResponse, webResponse: Re
 		} else {
 			const reader = body.getReader();
 			res.on('close', () => {
-				reader.cancel().catch((error: unknown) => {
-					// eslint-disable-next-line no-console
-					console.error('An unexpected error occurred in the middle of the stream.', error);
+				reader.cancel().catch(() => {
+					// Don't log here, or errors will get logged twice in most cases
 				});
 			});
 			while (true) {