Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewTransitions: Call to sharp().toBuffer() in nested component breaks view transitions #8669

Closed
1 task
coolroman opened this issue Sep 26, 2023 · 0 comments · Fixed by #8710
Closed
1 task
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: view transitions Related to the View Transitions feature (scope)

Comments

@coolroman
Copy link

Astro Info

Astro                    v3.1.4
Node                     v18.17.1
System                   macOS (arm64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

I am using sharp library to generate previews for the images. Preview is generated by calling to sharp(...).toBuffer() and then used as an inline style with base64 encoded image for "background-image: url(...)".
The issue is that view transitions work for the first image only.

Minimal reproducible example is provided.

What's the expected result?

View transitions work for all images with transition:name.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-rbkdv6?file=src%2Flib.ts%3AL59,src%2Fpages%2Findex.astro%3AL10,src%2Fcomponents%2FImage.astro%3AL23

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Sep 26, 2023
@bluwy bluwy added the feat: view transitions Related to the View Transitions feature (scope) label Sep 26, 2023
@matthewp matthewp added - P3: minor bug An edge case that only affects very specific usage (priority) and removed needs triage Issue needs to be triaged labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: view transitions Related to the View Transitions feature (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants