Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes View transition styles being missing when component used multip… #8710

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

matthewp
Copy link
Contributor

…le times

Changes

Testing

  • Test added that checks for the right number of styles.

Docs

N/A, bug fix.

@matthewp matthewp requested a review from a team as a code owner September 29, 2023 21:06
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: 335ec85

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 29, 2023
@martrapp
Copy link
Member

At first I was surprised that only the initialization of the data structure and the collection of the data is affected by the change. It doesn't seem to have any effect on the use of the structure by the consumers. I guess we were only interested in values() for Map like Set.

LGTM

@matthewp matthewp removed the request for review from a team October 2, 2023 12:51
@matthewp matthewp merged commit 4c2bec6 into main Oct 2, 2023
14 checks passed
@matthewp matthewp deleted the vt-mult branch October 2, 2023 12:51
@astrobot-houston astrobot-houston mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewTransitions: Call to sharp().toBuffer() in nested component breaks view transitions
2 participants