Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where dev toolbar x-ray didn't escape props content #10400

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix an issue where dev toolbar x-ray didn't escape props content #10400

merged 3 commits into from
Mar 12, 2024

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Mar 12, 2024 •
edited
Loading

Changes

Testing

  • A test case is added
  • Current tests should pass

Docs

  • N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: cdcd509

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 12, 2024
Princesseuh
Princesseuh approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Princesseuh Princesseuh merged commit 629c9d7 into withastro:main Mar 12, 2024
13 checks passed
@mingjunlu mingjunlu deleted the fix/toolbar-renders-props-content-as-html branch March 12, 2024 11:30
@astrobot-houston astrobot-houston mentioned this pull request Mar 12, 2024
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesseuh Princesseuh Princesseuh approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
2 participants
@mingjunlu @Princesseuh