Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing attribute popovertargetaction #11034

Conversation

arganaphang
Copy link
Contributor

Changes

  • add popovertargetaction into ButtonHTMLAttributes and InputHTMLAttributes

Testing

I manually tested the change in a local project

Docs

N/A

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 82c3de2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 14, 2024
@ematipico
Copy link
Member

Can you add a changeset? https://github.com/withastro/astro/blob/main/CONTRIBUTING.md#making-a-pull-request

@github-actions github-actions bot added the semver: major Change triggers a `major` release label May 14, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@arganaphang arganaphang force-pushed the fix/missing-attribute-popovertargetaction branch from 5275973 to 82c3de2 Compare May 14, 2024 07:57
@arganaphang
Copy link
Contributor Author

Can you add a changeset? https://github.com/withastro/astro/blob/main/CONTRIBUTING.md#making-a-pull-request

added
but i accidentally set changeset to major, already fixed, but the label semver: major still appear, can you update it? @ematipico

@ematipico ematipico removed the semver: major Change triggers a `major` release label May 14, 2024
@Princesseuh Princesseuh merged commit 5f2dd45 into withastro:main May 14, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 14, 2024
@arganaphang arganaphang deleted the fix/missing-attribute-popovertargetaction branch August 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants