Add copy support for Wayland via wl-copy #11964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6478752 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Princesseuh
reviewed
Sep 10, 2024
Princesseuh
approved these changes
Sep 10, 2024
bluwy
approved these changes
Sep 11, 2024
| @@ -86,8 +95,9 @@ async function copyToClipboard(text: string) { | |||
| if (!shouldCopy) return; | |||
|
|
|||
| try { | |||
| execSync(command, { | |||
| input: text.trim(), | |||
| execSync(command.replaceAll('$0', text), { | |||
There was a problem hiding this comment.
A bit worried with doing a plain replacement this way that could expose executing arbitrary commands, but it looks like we don't accept any user input that reaches here, so probably fine for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
whichwhenxclipis not found in the pathastro infocopy support for Wayland users viawl-copyTesting
Manually tested as tests for the cli don't cover
infoand we don't have the right test environment.Docs
No docs needed