Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default exclude to tsconfigs #11982

Merged
merged 3 commits into from
Sep 13, 2024
Merged

feat: add default exclude to tsconfigs #11982

merged 3 commits into from
Sep 13, 2024

Conversation

Princesseuh
Copy link
Member

With TS 5.5, we can now do this in our default templates. For users using lower versions, it just won't work. For users using any other dist dir, they'll want to update their own exclude anyway, overriding this. If someone has changed the default output, and has a dist folder that is not supposed to be ignored by TS (???) they can also override this in their own tsconfig.json.

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 66c67ce

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 12, 2024
@Princesseuh Princesseuh changed the title Fixes typo. (#11968) feat: add default exclude to tsconfigs Sep 12, 2024
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but 2 questions:

  • do we need a changeset for that? (i guess so)
  • should we update the include as well? with ["${configDir}/.astro/types.d.ts", "${configDir}/**/*"]

@Princesseuh
Copy link
Member Author

Yeah, we can do the include as well, should be fine with the **/*, but I'll test it to make sure!

@github-actions github-actions bot added the semver: major Change triggers a `major` release label Sep 13, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@Princesseuh Princesseuh merged commit d84e444 into next Sep 13, 2024
2 checks passed
@Princesseuh Princesseuh deleted the feat/default-exclude branch September 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants