Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat images with initial slash as local, and resolve with vite #12030

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Sep 19, 2024

Changes

Previously we treated images that start with a slash as public images, and didn;t process them. Turns out that this is changed behaviour, so we'll switch to resolving them via Vite.

Fixes #12025

Testing

Added several test cases

Docs

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: b0eed33

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 19, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pics

@@ -16,7 +16,7 @@ export function imageSrcToImportId(imageSrc: string, filePath?: string): string
imageSrc = removeBase(imageSrc, IMAGE_IMPORT_PREFIX);

// We only care about local imports
if (isRemotePath(imageSrc) || imageSrc.startsWith('/')) {
if (isRemotePath(imageSrc)) {
Copy link
Contributor

@jcayzac jcayzac Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: isRemote() incorrectly assumes remote URLs all start with a protocol, so the code now won't catch //foo.com/bar.jpg anymore, which it still should?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants