-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-astro updates #12083
create-astro updates #12083
Conversation
🦋 Changeset detectedLatest commit: e6425d2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Todo:
|
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinging, Erika!
So, off the top of my head (I'll make a task for myself to follow up):
-
We don't need anything in the Upgrade guide since technically this can't break an existing project. I suspect this will either be more of a "discovery" or something to hype for the blog post.
-
I will need to update the tutorial that is currently expecting the
base
TS setting, and the current "minimal" template -
I will check the TypeScript/config pages that describe our settings to make sure nothing expects base and describes updating that
-
document the new
--add
flag -
As much as we can manage (which might not be much depending on our whole sidebar recreation? This might have to be the next quarter project), we can look at updating code examples with Tabs for JS/TS, or showing more TS examples in docs now that we can expect the basic project to use
strict
and more people to need to avoid squiggles. 😅 I will see if I can wrangle some maintainers/contributors to start prepping for this at least.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like the running the basics template locally causes some dynamic import errors with Vite. But I think that could be investigated separately in the future.
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> Co-authored-by: Reuben Tier <otterlord.dev@gmail.com>
Changes
This PR includes a few changes to the experience of creating a new project in Astro:
// @ts-check
has been added to all the examples config filesastro check
is no longer enabled by default for the build commandcreate-astro
now takes a--add
flag, allowing one to add a bunch of integrations in one command.Basic example rework
The basics template has been reworked to provide a more minimal template, allowing it to serve as a mix between "Basics" and "Minimal":
.astro
, allowing one to still inspect how you'd achieve things in Astro. This component takes in a props to customise the title, still allowing for the implicit teaching of props. A very basic layout (similar to Emmet'sdoc
command) is included, both to setup basic HTML stuff and teach the user about templates / slotsTesting
Added / updated tests
Docs
We'll update the docs:tm: