Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-component-undefined-svelte-v5 (#12102) #12129

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix-component-undefined-svelte-v5 (#12102) #12129

merged 1 commit into from
Oct 5, 2024

Conversation

martrapp
Copy link
Member

@martrapp martrapp commented Oct 5, 2024

    • fix: 'component is not defined' error when unmount svelte 5 component
  • added changeset

  • Moving unmount listener to where the component is defined.

  • Update .changeset/eighty-ligers-punch.md

Cherry-picked from dcc1e89

* - fix: 'component is not defined' error when unmount svelte 5 component

* added changeset

* Moving unmount listener to where the component is defined.

* Update .changeset/eighty-ligers-punch.md

Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>

---------

Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
Copy link

changeset-bot bot commented Oct 5, 2024

🦋 Changeset detected

Latest commit: 6c02d15

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Oct 5, 2024
@martrapp martrapp merged commit 5bc6223 into main Oct 5, 2024
13 checks passed
@martrapp martrapp deleted the mt/cp branch October 5, 2024 11:16
@astrobot-houston astrobot-houston mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants