Revert "fix custom assetFileNames issue (#12449)"
#12746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e6b8017. This change caused source maps to be left in the client folder, exposing them into the server.
|
github-actions
bot
added
the
pkg: astro
|
!preview sm-assets |
CodSpeed Performance ReportMerging #12746 will not alter performanceComparing Summary
|
ematipico
approved these changes
Dec 16, 2024
Merged
ematipico
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Revert "fix custom `assetFileNames` issue (#12449)" (#12746) * Revert "fix custom `assetFileNames` issue (#12449)" This reverts commit e6b8017. This change caused source maps to be left in the client folder, exposing them into the server. * Add changeset * Clean sourcemaps from static output (#12749) * Clean sourcemaps from static output * Add changeset * Update test to look at frontend sourcemaps * Revert "fix custom `assetFileNames` issue (#12449)" (#12746) * Revert "fix custom `assetFileNames` issue (#12449)" This reverts commit e6b8017. This change caused source maps to be left in the client folder, exposing them into the server. * Add changeset * Clean sourcemaps from static output (#12749) * Clean sourcemaps from static output * Add changeset * Update test to look at frontend sourcemaps * [ci] format * fix build * Skip experimental cc tests * remove unused params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e6b8017.
This change caused source maps to be left in the client folder, exposing them into the server.
Reverting because the old logic was flawed in that it assumed that everything that gets put into the assets folder comes from inside of the vite build and is an "asset" type, but that's not true for sourcemaps. What other sorts of files might be created during the build that we are not cleaning?